Merge pull request #8650 from OpenMined/fix-post-release-test-workflow

pass test pypi url as extra index
OpenMined · Apr 2, 2024 · 1adf8a2 · 1adf8a2
2 parents da6f7a6 + 9168a86
commit 1adf8a2
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 5 deletions.
diff --git a/.github/workflows/cd-post-release-tests.yml b/.github/workflows/cd-post-release-tests.yml
@@ -169,12 +169,13 @@ jobs:
             ${{ runner.os }}-pip-py${{ matrix.python-version }}-
 
       - name: Install Syft
+        shell: bash
         run: |
           if [[ ${{inputs.release_platform}} == "REAL_PYPI" ]]; then
             pip install syft==${{inputs.syft_version}}
           fi
           if [[ ${{ inputs.release_platform }} == "TEST_PYPI" ]]; then
-            pip install -i https://test.pypi.org/simple/ syft==${{inputs.syft_version}}
+            pip install --extra-index-url https://test.pypi.org/simple/ syft==${{inputs.syft_version}}
           fi
 
       - name: Check Syft version
@@ -283,7 +284,7 @@ jobs:
           SYFT_VERSION: ${{ inputs.syft_version }}
         run: |
           if [[ ${{ inputs.release_platform }} == "TEST_PYPI" ]]; then
-            pip install -i https://test.pypi.org/simple/ syft[data_science,dev]==${{ inputs.syft_version }}
+            pip install --extra-index-url https://test.pypi.org/simple/ syft[data_science,dev]==${{ inputs.syft_version }}
           fi
           if [[ ${{ inputs.release_platform }} == "REAL_PYPI" ]]; then
             pip install syft[data_science,dev]==${{ inputs.syft_version }}

diff --git a/notebooks/api/0.8/06-multiple-code-requests.ipynb b/notebooks/api/0.8/06-multiple-code-requests.ipynb
@@ -93,7 +93,7 @@
    "metadata": {},
    "outputs": [],
    "source": [
-    "dataset2 = sy.Dataset(name=\"My Sample Dataset - II\")\n",
+    "dataset2 = sy.Dataset(name=\"Age Dataset\")\n",
     "asset2 = sy.Asset(name=\"Sample Data - II\")\n",
     "asset2.set_obj(sample_data * 10)\n",
     "asset2.set_mock(mock_sample_data * 10, mock_is_real=False)\n",
@@ -174,7 +174,7 @@
    "metadata": {},
    "outputs": [],
    "source": [
-    "assert len(datasets) == 2\n",
+    "assert len(datasets) == 1\n",
     "dataset_ptr = datasets[0]\n",
     "dataset_ptr"
    ]
@@ -477,7 +477,7 @@
    "metadata": {},
    "outputs": [],
    "source": [
-    "datasets = ds_client.datasets.search(name=\"My Sample Dataset - II\")\n",
+    "datasets = ds_client.datasets.search(name=\"Age Dataset\")\n",
     "dataset_ptr2 = datasets[0]\n",
     "dataset_ptr2"
    ]
@@ -552,6 +552,14 @@
     "if node.deployment_type.value in [\"python\", \"single_container\"]:\n",
     "    node.land()"
    ]
+  },
+  {
+   "cell_type": "code",
+   "execution_count": null,
+   "id": "40",
+   "metadata": {},
+   "outputs": [],
+   "source": []
   }
  ],
  "metadata": {

diff --git a/packages/syft/tests/syft/stores/queue_stash_test.py b/packages/syft/tests/syft/stores/queue_stash_test.py
@@ -1,5 +1,6 @@
 # stdlib
 from threading import Thread
+import time
 from typing import Any
 
 # third party
@@ -377,6 +378,7 @@ def helper_queue_update_threading(root_verify_key, create_queue_cbk) -> None:
     repeats = 5
 
     queue = create_queue_cbk()
+    time.sleep(1)
 
     obj = mock_queue_object()
     queue.set(root_verify_key, obj, ignore_duplicates=False)