Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhpStan: some fixes #4363

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

PhpStan: some fixes #4363

wants to merge 4 commits into from

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Nov 17, 2024 •
edited
Loading

Fixed some error.

@github-actions github-actions bot added Component: PayPal Relates to Mage_Paypal Component: Core Relates to Mage_Core Component: Catalog Relates to Mage_Catalog Component: Reports Relates to Mage_Reports Component: CatalogInventory Relates to Mage_CatalogInventory Component: lib/Varien Relates to lib/Varien Component: Usa Relates to Mage_Usa Component: Eav Relates to Mage_Eav Component: Adminhtml Relates to Mage_Adminhtml Component: Page Relates to Mage_Page Component: CatalogRule Relates to Mage_CatalogRule Component: Rating Relates to Mage_Rating Component: Payment Relates to Mage_Payment Component: Oauth Relates to Mage_Oauth Component: Index Relates to Mage_Index Component: Bundle Relates to Mage_Bundle Component: CatalogIndex Relates to Mage_CatalogIndex Component: ImportExport Relates to Mage_ImportExport Component: Directory Relates to Mage_Directory Component: CatalogSearch Relates to Mage_CatalogSearch Component: Authorizenet Relates to Mage_Authorizenet Component: Paygate Relates to Mage_Paygate Component: lib/* Relates to lib/* phpstan labels Nov 17, 2024
@sreichel sreichel marked this pull request as draft November 17, 2024 09:32
@fballiano
Copy link
Contributor

what does "k/t" mean?

@github-actions github-actions bot added the Component: Sales Relates to Mage_Sales label Nov 18, 2024
sreichel
sreichel commented Nov 18, 2024
View reviewed changes
.phpstan.dist.baseline.neon
Comment on lines +2154 to 2156
message: "#^Parameter \\#8 \\$productId of method Mage_Catalog_Model_Product_Type_Price\\:\\:calculatePrice\\(\\) expects int\\|null, array given\\.$#"
count: 1
path: app/code/core/Mage/CatalogIndex/Model/Data/Abstract.php
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible bug. Check later.

@sreichel sreichel marked this pull request as ready for review November 18, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Authorizenet Relates to Mage_Authorizenet Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogIndex Relates to Mage_CatalogIndex Component: CatalogInventory Relates to Mage_CatalogInventory Component: CatalogRule Relates to Mage_CatalogRule Component: CatalogSearch Relates to Mage_CatalogSearch Component: Core Relates to Mage_Core Component: Directory Relates to Mage_Directory Component: Eav Relates to Mage_Eav Component: ImportExport Relates to Mage_ImportExport Component: Index Relates to Mage_Index Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Oauth Relates to Mage_Oauth Component: Page Relates to Mage_Page Component: Paygate Relates to Mage_Paygate Component: Payment Relates to Mage_Payment Component: PayPal Relates to Mage_Paypal Component: Rating Relates to Mage_Rating Component: Reports Relates to Mage_Reports Component: Sales Relates to Mage_Sales Component: Usa Relates to Mage_Usa phpstan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sreichel @fballiano