Fixed null deprecation in Mage/Catalog/Model/Product/Option/Type/Text

[kiatng]

    [type] => 8192:E_DEPRECATED
    [message] => trim(): Passing null to parameter #1 ($string) of type string is deprecated
    [file] => .../app/code/core/Mage/Catalog/Model/Product/Option/Type/Text.php
    [line] => 36

[sreichel]

Its an issue in core or 3rd-party?

[kiatng]

It happened in custom code to create an order programmatically, I agree that null check for values can be placed here. But I feel the core should be more tolerant because it works before. It's a matter of opinion, I have no issue if others feel otherwise.

[sreichel]

Mhh, instead of adding null-checks everywhere (not only in this PR), why not to override the magic method calls? Add ... ?

    public function getUserValue(): string
    {
        return (string) $this->getDataByKey('user_value');
    }

[kiatng]

Commit 2 doesn't work: I get Warning: Array to string conversion in .../app/code/core/Mage/Catalog/Model/Product/Option/Type/Default.php on line 59 (in my version in production)

[kiatng]

It's not that straight forward!

[sreichel]

you made the change in the wrong file. check https://github.com/kiatng/magento-lts/pull/2/files