-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDEV] Support for xhprof
/xhgui
#4325
Conversation
xhprof
/xhgui
xhprof
/xhgui
@sreichel - Before starting testing I would like to clarify all the steps based on the description.
if (file_exists("/mnt/ddev_config/xhgui/collector/xhgui.collector.php")) {
require_once "/mnt/ddev_config/xhgui/collector/xhgui.collector.php";
}
<?php
if (getenv('IS_DDEV_PROJECT') && getenv('NO_XHGUI') !== '1') {
if (file_exists($xhgui = '/mnt/ddev_config/xhgui/collector/xhgui.collector.php')) {
require_once $xhgui;
}
}
Have I missed anything so far? It will help me to add this information in this file https://github.com/OpenMage/magento-lts/blob/f39a667c9d9eda4c4c015e29f40c78d8ed2dec38/docs/content/developers/ddev.md, after merging. In this comment ddev/ddev-xhgui#33 (comment) you say the step 2 from above has no effect, we don't need to edit app/Mage.php, but it is still in the DDEV-XHGui documentation. |
No. This should be all.
DOC will be updated later. |
OK. Please resolve the conflict related to the composer.lock file. |
# Conflicts: # composer.lock
Thanks. :) But wait for ddev/ddev-xhgui#33. This could be automated a bit. |
Description (*)
Support https://github.com/ddev/ddev-xhgui
Related Pull Requests
Manual testing scenarios (*)
Using DDEV ...
ddev.xhgui.php
toapp/etc/includes
ddev xhprof
... to enable profilerddev xhgui
... to watch results