Added more PhpUnit tests #4236
Merged
Added more PhpUnit tests #4236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
environment
Component: PayPal
kiatng
reviewed
Oct 15, 2024
github-actions
bot
added
the
Component: ImportExport
kiatng
previously approved these changes
Oct 16, 2024
# Conflicts: # .phpstan.dist.baseline.neon # app/code/core/Mage/Catalog/Model/Url.php
# Conflicts: # .phpstan.dist.baseline.neon
kiatng
reviewed
Oct 24, 2024
addison74
approved these changes
Oct 27, 2024
kiatng
approved these changes
Oct 28, 2024
fballiano
added a commit
to MahoCommerce/maho
that referenced
this pull request
Oct 29, 2024
fballiano
added a commit
to MahoCommerce/maho
that referenced
this pull request
Oct 29, 2024
|
this PR should be about unit tests and it's mainly about phpstan, but also, did you notice it introduces 3-4 new errors in phpstan? |
|
to write the tests, i have to view the files. when phpstan issues can be fixed at the same time .... yes, i did, fixing one phpstan error can reveal others, but this can become endless story to fix all follow-up errors. Better +5 and -150 for now? They will be fixed later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Comments
To exclude slow running tests;