Unified admin grid columns and added XML configuration

[sreichel]

Description (*)

• makes all entity_id grid columns searchable from to
• disallow/ignore non-numeric input on price/currency/range grid columns (*)
• removed useless "'sortable' => true"
• bugfix: revmoved return parent::renderCss() . ' a-right';

(*) Note: instead of having zero results, as suggested in mentioned issue, it will ignore input and return all products.

Fixed Issues (if relevant)

1. Fixes Filtering columns grid - Issue with products having the price zero #3158

Update

The configuratuion for grid column default values went from php-property to XML config.

To customize see ... app/code/core/Mage/Adminhtml/etc/config.xml

    <grid>
        <column>
            <default>
                <index>
                    <entity_id>
                        <align>right</align>
                        <type>number</type>
                    </entity_id>
                </index>
                <type>
                    <action>
                        <filter>false</filter>
                        <sortable>false</sortable>
                        <width>40</width>
                    </action>
                    <currency>
                        <align>right</align>
                        <index>price</index>
                    </currency>
                    <date>
                        <width>140</width>
                    </date>
                    <datetime>
                        <width>170</width>
                    </datetime>
                    <number>
                        <align>right</align>
                    </number>
                    <price>
                        <align>right</align>
                        <index>price</index>
                    </price>
                    <store>
                        <index>store_id</index>
                        <store_view>true</store_view>
                        <width>160</width>
                    </store>
                </type>
            </default>
        </column>
    </grid>

[addison74]

If we fix this problem, all the grids in the Backend will have to be revised. For example, the Manage Customers grid, we are allowed to input strings on the ID column for the From and To inputs.

[sreichel]

If we fix this problem, all the grids in the Backend will have to be revised

Yes, i know, but please not here in this PR.

Better make small steps ...

edit:

Pls collect all the grids that need changes, make new issue and we move on.

[addison74]

@sreichel - This is the grids list which have columns that allow searching strings and return zero as results. In order to check I had to change records in the database. I hope I did not miss anything. This PR solves only one of the issues Catalog > Products - Price column.

Sales > Orders

• G.T. (Base) column
• G.T. (Purchased) column

Sales > Invoices

• Amount column

Sales > Shipments

• Total Qty column

Sales > Credit Memos

• Refunded column

Sales > Tax > Manage Tax Zone & Rates

• Rate column

Catalog > Products

• Price column

Catalog > Products > Edit Product > Related Products tab

• Price column
• Position colum

Catalog > Products > Edit Product > Up-sells Products tab

• Price column
• Position colum

Catalog > Products > Edit Product > Cross-sells Products tab

• Price column
• Position colum

Catalog > Products > Edit Product > Product Tags tab

• # of Use column

Catalog > Products > Edit Product > Associated Products tab (configurable)

• Price column

Catalog > Categories > Category Products tab

• Price column
• Position column

Catalog > Search Terms

• Results column
• Number of Uses column

Promotions > Shopping Cart Price Rules

• Times used column

Newsletter > Newsletter Queue

• Processed column
• Recipients column

Newsletter > Newsletter Problem Reports

• Error Code column

Reports > Shopping Cart > Abandoned carts

• Number of Items column
• Quantity of Items column
• Subtotal column

Reports > Producs > Low stock

• Stock Qty column

Reports > Search Terms

• Results column
• Hits column

[addison74]

Nice work. I checked all the files and the result in the Backend.

[addison74]

I have identified a problem. In Catalog > Manage Products on the ID column it is now possible to search within a range. Similar grids are in Related Products, Up-sells, Cross-sells, Associate Products and many more, but which only remained with the search for an ID. Shouldn't they also be modified to be unified?

[sreichel]

Not all grids are covered yet (having another index then entity_id)

If you find some, please list them.

[addison74]

Grids with ID columns which should have From/To inputs.

• Catalog > Manage Products > Product Edit > Related Products

• Catalog > Manage Products > Product Edit > Up-sells

• Catalog > Manage Products > Product Edit > Cross-sells

• Catalog > Manage Products > Product Edit > Product Reviews

• Catalog > Manage Products > Product Edit > Associated Products (configurable)

• Catalog > Manage Categories > Category Products tab

• Catalog > URL Rewrite Management

• Catalog > Search Terms

• Catalog > Review and Ratings > Customer Reviews > Pending Reviews

• Catalog > Review and Ratings > Customer Reviews > All Reviews

• Catalog > Google Sitemap

• Promotions > Catalog Price Rules

• Promotions > Shopping Cart Price Rules

• Newsletter > Newsletter Templates

• Newsletter > Newsletter Queue

• Newsletter > Newsletter Subscribers

• Newsletter > Newsletter Problems Reports

• System > Webservices > SOAP Users

• System > Webservices > SOAP Roles

• System > Webservices > Rest Roles

• System > Webservices > OAuth Consumers

• System > Webservices > OAuth Authorized Tokens

• System > Webservices > My Applications

• System > Import/Export > Dataflow Profiles

• System > Import/Export > Advanced Profiles

• System > Transactional Emails

• System > Permissions > Users

• System > Permissions > Roles

• System > Permissions > Variables

• System > Permissions > Blocks

Before moving on to the changes, I think we should evaluate these grids, because not all of them need changes, but those where the need to search within a rage is really helpful.

[sreichel]

Thanks. I'll do it step by step :)

[sreichel]

Please checkout latest commit.

This was fixed in app/code/core/Mage/Adminhtml/Block/Widget/Grid.php

[sreichel]

Date-placeholder should have "From Date", or "dd/mm/yy" to make it perfect ...

PR welcome.

[sreichel]

@addison74 thanks for your reviews. If you have improvements, please use githubs "suggestion"-feature or make a PR to my repo.

For me, current version looks okay.

If you want to remove/improve labels/placeholders, please create a PR. All these mini-changes takes a lot of time - wasting my time.

[sreichel]

It is pretty strange to see two times the same text, From From, To To

Made placeholders invisible in legacy theme.

[addison74]

It is pretty strange to see two times the same text, From From, To To

Made placeholders invisible in legacy theme.

It is much better.

[kiatng]

@sreichel Conflict to resolve.