Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified admin grid columns #4225

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Unified admin grid columns #4225

wants to merge 6 commits into from

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Sep 24, 2024

Description (*)

  • makes all entity_id grid columns searchable from to
  • disallow/ignore non-numeric input on price/currency/range grid columns (*)
  • removed useless "'sortable' => true"
  • bugfix: revmoved return parent::renderCss() . ' a-right';

(*) Note: instead of having zero results, as suggested in mentioned issue, it will ignore input and return all products.

Fixed Issues (if relevant)

  1. Fixes Filtering columns grid - Issue with products having the price zero #3158

@github-actions github-actions bot added the Component: Adminhtml Relates to Mage_Adminhtml label Sep 24, 2024
@ADDISON74
Copy link
Contributor

If we fix this problem, all the grids in the Backend will have to be revised. For example, the Manage Customers grid, we are allowed to input strings on the ID column for the From and To inputs.

@sreichel
Copy link
Contributor Author

sreichel commented Sep 24, 2024

If we fix this problem, all the grids in the Backend will have to be revised

Yes, i know, but please not here in this PR.

Better make small steps ...

edit:

Pls collect all the grids that need changes, make new issue and we move on.

@ADDISON74
Copy link
Contributor

ADDISON74 commented Sep 29, 2024

@sreichel - This is the grids list which have columns that allow searching strings and return zero as results. In order to check I had to change records in the database. I hope I did not miss anything. This PR solves only one of the issues Catalog > Products - Price column.

Sales > Orders

  • G.T. (Base) column
  • G.T. (Purchased) column

Sales > Invoices

  • Amount column

Sales > Shipments

  • Total Qty column

Sales > Credit Memos

  • Refunded column

Sales > Tax > Manage Tax Zone & Rates

  • Rate column

Catalog > Products

  • Price column

Catalog > Products > Edit Product > Related Products tab

  • Price column
  • Position colum

Catalog > Products > Edit Product > Up-sells Products tab

  • Price column
  • Position colum

Catalog > Products > Edit Product > Cross-sells Products tab

  • Price column
  • Position colum

Catalog > Products > Edit Product > Product Tags tab

  • # of Use column

Catalog > Products > Edit Product > Associated Products tab (configurable)

  • Price column

Catalog > Categories > Category Products tab

  • Price column
  • Position column

Catalog > Search Terms

  • Results column
  • Number of Uses column

Promotions > Shopping Cart Price Rules

  • Times used column

Newsletter > Newsletter Queue

  • Processed column
  • Recipients column

Newsletter > Newsletter Problem Reports

  • Error Code column

Reports > Shopping Cart > Abandoned carts

  • Number of Items column
  • Quantity of Items column
  • Subtotal column

Reports > Producs > Low stock

  • Stock Qty column

Reports > Search Terms

  • Results column
  • Hits column

- makes all "entity_id" grid columns searchable "from" "to"
- disallow/ignore non-numeric input on price/currency/range grid columns
- removed useless "'sortable' => true"
@github-actions github-actions bot added Component: Eav Relates to Mage_Eav Component: Oauth Relates to Mage_Oauth Component: Bundle Relates to Mage_Bundle Component: Api2 Relates to Mage_Api2 phpstan labels Sep 29, 2024
@sreichel sreichel changed the title Fixes price filter with non-numeric input Unified admin grid columns Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Api2 Relates to Mage_Api2 Component: Bundle Relates to Mage_Bundle Component: Eav Relates to Mage_Eav Component: Oauth Relates to Mage_Oauth phpstan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filtering columns grid - Issue with products having the price zero
2 participants