-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install TinyMCE 7.3 via composer #4113
base: main
Are you sure you want to change the base?
Conversation
* Rector: CQ - UnusedForeachValueToArrayKeysRector See Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector * fixes + phpstan See fix at rector: rectorphp/rector-src#6164
This reverts commit 3d7eaf6.
Very good idea, but @fballiano, @empiricompany and I worked on a custom version for TinyMCE which is now available in version 20. Installing TinyMCE with Composer will benefit the version we have already in OpenMage or do we need some patches for Composer? |
@ADDISON74 i have seen no changes made to TinyMCE itself, so the files are the same as currently used. |
@sreichel - This is good. I will come back with a feedback after testing. |
@ADDISON74 note: when you install OM as composer dependency, you have to install that plugin too. |
Waiting for final response from TinyMCE, but it looks like we CAN use v7 ... Maybe some is really familiar with licensing ... answer so far.
OM is no derivative work from TinyMCE, so we dont have to put it under GPL itself. We use it in a non-commercial project. We follow (inherit?) GPL and all code is available to the community. From my understanding ... if someone uses a OM-fork as commercial product, HE had to put it under GPL - not we. Waiting for response, but v7 seems to work ... |
I didn't think to contact them, but what you say there seems to make sense. If we get an official answer that we can use version 7, that would be wonderful. If I'm not mistaken, Magento 2 is still at version 5. |
# Conflicts: # composer.lock
@sreichel - Did you get any reply from TinyMCE regarding using v7 in OpenMage? |
@ADDISON74 i dont know ... my email-account is currently locked and seems not so easy to get it unlocked. With this PR we are prepared for a possible 6.8.5 release that will come "for sure" (6.8 is supported till next year). |
# Conflicts: # composer.lock
No answer till now ... Ready to review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but what release should it go in?
It would only replace current tinymce 6.8.4 we already have ... |
I like the idea of this PR, but there are two critical issues that come to mind that need to be resolved:
IMHO The best thing in the future is to remove TinyMCE in favor of a minimal editor with only bold, italic, underline, etc. |
OpenMage can fork it, but I don't want to move it. It's not tied to OpenMage.
However ... you're right. Removing or replacing or make TinyMce optional is something we have to think about. |
Below are some points raised by an LLM such as Claude: Integrating GPL (GNU General Public License) licensed code into an OSL (Open Software License) project can lead to several complications due to the differences in these licenses. Here are the main issues:
I encourage all of you to focus particularly on point 2 |
This is what GNU recommends on its website "We urge you not to use the Open Software License for software you write. However, there is no reason to avoid running programs that have been released under this license." I don't know if Magento 1 was licensed to use TinyMCE, but OpenMage inherited it. At this moment TinyMCE v6 runs in OpenMage and can be removed at the request of the developer. Being a discussion with legal implications, it would be necessary to consult some lawyers. If there is an explicit agreement to use TinyMCE in Magento 1, there should be no problems. If there is none, an agreement from TinyMCE should be requested by our maintainers. |
@empiricompany that plug-in has a few hundred downloads and I doubt it comes from Openmage users. It has only 3 lines of code that are related to Openmage (check for magento-root-dir). TinyMCE v6 is released under MIT license, so it should be safe to use. Only v7 changed to GPL3 that's not compatible. I got no reply from customer support till now and made an official request some minutes ago. |
There was some confusion in the Tinymce community about the license change. A few days ago there was a thread about it, this is the last official comment where they tried to clarify: tinymce/tinymce#9453 (comment) It seems that the versions before 7 maintain the old licenses, even if the repository is the same and shows the GPL license |
Request already made there ... https://pi.tiny.cloud/l/2202/2024-04-25/dgy4qt
|
The discussions that I read in the TinyMCE repository will not remain without result. Magento 2 still uses version 5, we can continue to use version 6 in OpenMage without problems even after its EOL. In addition, there will be forks if the license policy is not changed. At this moment I would say let others decide, because things will not stay like this regarding v7, TinyMCE risks losing many supporters very fast. If they didn't block the conversation, opinions would still flow today. |
# Conflicts: # .gitignore # composer.json # composer.lock
Thanks to @colinmollenhour who helps to finish that ...
❤️ |
Quick update: I met with Kate, everything sounded very straightforward and reasonable. There will be no cost to us or our users unless and until we approach/surpass $2mm annual revenue. She sent a license for review. I will look over it next week. Sven also has it in his email. |
Thanks Colin.
We have no controlll over users revenue. I'd suggest to ship OM with v7, but leave a WebNotification that they either have to downgrade to v6.8 or "get in contact" with TinyMCE to pay the fees if they pass the anual $2mm ... That leads to "How to handle" zip-archive? |
Good job folks. We can continue with 6.8 version because it will benefit from support for a while and then there will surely be active forks, as happened with ZF1-Future. We can offer the option to install version 7 mentioning that if annual revenue is over 2 million USD then either pay a fee or downgrade to 6.8. By the way, Magento 2 still uses version 5. |
This license request was for to not stay on v6. (???) |
Description (*)
I've updated the copy-plugin to work if you install OpenMage as composer dependency.
Related Pull Requests