Allow setting admin user notification email receiver

[Judx]

Description (*)

This PR allows setting receiver email to "New Admin User Create Notification". Default is that email is sent to store general email address. In some cases it is necessary to allow changing the notification receiver.

Related Pull Requests

Depends on and includes changes from #3721

Fixed Issues (if relevant)

No.

Manual testing scenarios (*)

1. Pull changes.
2. Find and set email address in: System -> Admin -> Security -> Notification Email Receiver
3. Create new admin user and see that the notification email is received by the specified address.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[pquerner]

Zend_Validate::is($receiverEmail, 'EmailAddress') perhaps?

[luigifab]

Yes, because FILTER_VALIDATE_EMAIL is not used.

[pquerner]

I would leave the typo as-is. Yes, you move the value to the new setting, but legacy code may still use the old xpath.

[luigifab]

For legacy code, this can be used, if I remember correctly:

<crate_admin_user_notification deprecated="true">
    <config_path>admin/security/create_admin_user_notification</config_path>
</crate_admin_user_notification>

[pquerner]

Where is that @luigifab ?

[luigifab]

Here:

magento-lts/app/code/core/Mage/Paypal/etc/system.xml

Lines 29 to 40 in 6ea8cf0

	<account translate="label" module="paypal">
	<label>Merchant Location</label>
	<fieldset_css>paypal-config</fieldset_css>
	<expanded>1</expanded>
	<sort_order>5</sort_order>
	<show_in_default>1</show_in_default>
	<show_in_website>1</show_in_website>
	<frontend_model>paypal/adminhtml_system_config_fieldset_location</frontend_model>
	<fields>
	<merchant_country translate="label comment">
	<label>Merchant Country</label>
	<config_path>paypal/general/merchant_country</config_path>

[pquerner]

This is ok to change.

[addison74]

Before changing the comment, please check if there is a translation for that phrase. If exists you should change only the CSV file.

[fballiano]

yep, needs to be changed in Mage_Core.csv instead of here, so that we don't break language packs

[fballiano]

In #3721 was decided not to create a breaking change to fix a typo, let's please address the comments made by other users if possible