Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the permissions required to create a release #21

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

Assumeru
Copy link
Contributor

@Assumeru Assumeru commented Nov 8, 2024

Because apparently this repo isn't using the default permissions.

https://github.com/softprops/action-gh-release?tab=readme-ov-file#permissions

@AnyOldName3
Copy link
Member

Because this is a safer version of a change that I could do in the settings tab without the wait 24h to accumulate reviews policy getting in the way, and there are still a couple of other code review barriers before any fallout from this could affect OpenMW, and because the repeated surprise waits are irritating Evil Eye, I'm going to merge this early. As with all early merges, anyone has permission to unilaterally revert this without making the revert go through code review.

@AnyOldName3 AnyOldName3 merged commit a89f46c into OpenMW:master Nov 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants