Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paint surface #2459

Merged
merged 34 commits into from May 19, 2024
Merged

Paint surface #2459

merged 34 commits into from May 19, 2024

Conversation

duncanspumpkin
Copy link
Contributor

@duncanspumpkin duncanspumpkin commented Apr 25, 2024

Complete!

@AaronVanGeffen
Copy link
Member

AaronVanGeffen commented May 14, 2024

To check the results from this PR, I've created two sets of giant screenshots of the usual Matsku Playthrough save. Both sets contain screenshots of the four rotations. To make these screenshots, I hacked the game loop to not progress at all, effectively pausing the game.

Observations below, with different pixels highlighted in red.

  • Areas under bridges are no longer shaded.
Screenshot 2024-05-14 at 20 02 42 Screenshot 2024-05-14 at 20 02 58
  • Water seems to be painted slightly differently. The tone is notably darker. Could it be off by one in an animation sequence, somehow?
Screenshot 2024-05-14 at 20 03 08

@duncanspumpkin
Copy link
Contributor Author

Fixed those two issues.

@AaronVanGeffen
Copy link
Member

Can confirm water and shadows now appear properly.

Found one more issue with the Matsku map, but only on one rotation. Consider the edges around this city:

On master:
Screenshot 2024-05-15 at 14 20 23

On this PR:
Screenshot 2024-05-15 at 14 20 38

Diff:
Screenshot 2024-05-15 at 14 19 00

Copy link
Member

@AaronVanGeffen AaronVanGeffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks to be in order. Impressive work!

@AaronVanGeffen AaronVanGeffen added this to the v24.05.1+ milestone May 16, 2024
@duncanspumpkin duncanspumpkin merged commit 491e73f into OpenLoco:master May 19, 2024
9 checks passed
@duncanspumpkin duncanspumpkin deleted the paintSurface branch May 19, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants