Implement removeAirport game command #2454
Conversation
AaronVanGeffen
force-pushed
the
gc/remove-airport
branch
from
2ea8387
to
04a6be0
Compare
|
@duncanspumpkin I think that's the remaining bugs in the implementation worked out. Airports can be removed and created without issue now. |
| StationId stationId = StationId::null; | ||
| if ((flags & Flags::ghost) != 0) | ||
| { | ||
| return loc_49372F(stationId, *stationEl, args.pos, flags); |
There was a problem hiding this comment.
this isn't how we have generally written these functions normally we just do
if (!isGhost){
... // non ghost code
}
... // everyone code
i mean its fine to do its just a bit odd.
There was a problem hiding this comment.
Hmm, I needed it to understand the jumping that was going on. To be honest, I prefer having two functions of this length over one big function. Question is what to name it, though.
AaronVanGeffen
force-pushed
the
gc/remove-airport
branch
from
3389576
to
f812ae0
Compare
|
I've added the helper as requested in the latest commit. However, there must be a mistake, as it no longer completely removes the airport. Debugging suggests all parts are accounted for, however. Things appear to be working fine on the previous commit, so it must be due to these latest changes. I could do with a second pair of eyes on this. |
Has a few issues to be worked out still