Implement MapWindow::setMapPixels #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronVanGeffen
force-pushed
the
setMapPixels
branch
from
444202e
to
e7f8c91
Compare
AaronVanGeffen
force-pushed
the
setMapPixels
branch
from
8148984
to
9ed56db
Compare
AaronVanGeffen
force-pushed
the
setMapPixels
branch
from
c9ebad4
to
1c3ac17
Compare
AaronVanGeffen
force-pushed
the
setMapPixels
branch
from
9c94878
to
d7f2652
Compare
This comment was marked as outdated.
This comment was marked as outdated.
AaronVanGeffen
force-pushed
the
setMapPixels
branch
from
6c79550
to
03c6b9c
Compare
|
This is ready for review. I'm itching to refactor the window, with it now being fully implemented, hence #2447. However, refactoring it is beyond the scope of this PR, imo. |
AaronVanGeffen
changed the title
|
@LeftofZen The dithering effect should be present again now. |
This comment was marked as resolved.
This comment was marked as resolved.
LeftofZen
previously approved these changes
Apr 18, 2024
LeftofZen
dismissed
their stale review
Forgot to check water, which still has missing dithering
This comment was marked as resolved.
This comment was marked as resolved.
Argh, I thought I had fixed that, but I was still off-by-one. Should be all good now? |
duncanspumpkin
requested changes
May 15, 2024
duncanspumpkin
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.