Update track motion #2174
Draft
Update track motion #2174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanspumpkin
force-pushed
the
updateTrackMotion
branch
from
00b37d7
to
0ab747e
Compare
ZehMatt
reviewed
Nov 4, 2023
| switch (getSubType()) | ||
| { | ||
| case VehicleEntityType::head: | ||
| return updateTrackMotionT(*reinterpret_cast<VehicleHead*>(this), unk1); |
There was a problem hiding this comment.
I think we have a function as for this, having a visitor pattern for this would be a pretty good thing which skips the entire checking for the type then, I would propose to just use as for now and then we should look into adding visitSubType or something to make patterns like this easier.
duncanspumpkin
force-pushed
the
updateTrackMotion
branch
from
0ab747e
to
a82b549
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the main track update motion function that handles traveling along a track. It is not complete and I'm not entirely sure i want to go down this route with templates. I'm leaning to not doing it like this and adding more getters/setters to the VehicleCommon. There are a few other issues that need address before this is ready like fixing subposition data.