[WIP] feat: allow editing of code blocks before execution #612

ericrallen · 2023-10-10T00:32:50Z

Describe the changes you have made:

This work-in-progress introduces the ability to edit code in your default editor before running it.

When Open Interpreter asks if you want to run the provided code, there is a new option, %edit, which will allow you to edit the code.

It currently waits for you to come back and hit ENTER to continue execution.

Unfortunately, it seems to automatically run the edited code, and I haven't been able to get it back into the scan/run loop.

I tried using a few different file/directory watching Python packages, but it seems the file close event is not very easy to listen for and not consistent across platforms, so for the initial proof of concept, I’m relying on user intervention.

Demo

Testing Instructions

gh pr checkout https://github.com/KillianLucas/open-interpreter/pull/612
poetry run interpreter
Note: auto_run must be disabled so don't run it with -y or with auto_run: true in your config.yaml.
Provide an input that generates code
Example:

Solve FizzBuzz for 0 through 17. Don't explain the code or tell me your process or how FizzBuzz works. Just generate the code so we can execute it.
When asked if you want to run the code, enter the %edit magic command
Edit the code and save your changes
Come back to the Terminal and hit ENTER

Reference any relevant issue (Fixes #537)

I have performed a self-review of my code:

I have tested the code on the following OS:

Windows
MacOS
Linux

AI Language Model (if applicable)

ericrallen · 2023-10-10T00:34:59Z

interpreter/terminal_interface/terminal_interface.py

+ interpreter.messages.append({
+ **old_message,
+ "code": edited_code,
+ })


This doesn't seem to trigger getting back into the same Do you want to scan this code? / Do you want to run this code? loop and skips straight to execution.

It also doesn't render the code with syntax highlighting, which is a bummer.

ericrallen · 2023-10-10T00:36:10Z

interpreter/utils/open_file.py

This is the same logic that powered interpreter --config, but since we're opening other files now, it seemed logical to extract it into a utility that we can call whenever we need to open a specific path in the user's default application.

ericrallen · 2023-10-10T00:36:26Z

interpreter/utils/scan_code.py

@@ -1,34 +1,9 @@
 import os
 import subprocess
 from yaspin import yaspin
-from yaspin.spinners import Spinners


This was just an extraneous import.

ericrallen · 2023-10-10T00:38:48Z

interpreter/utils/edit_code.py

+
+ open_file(temp_file)
+
+ with yaspin(text=f" Editing {language_name} code...").green.right.dots as loading:


There's probably a better way to handle this. The big problem right now is that since we don't really get any kind of useful signal when the user is done, we can't automatically clean up the spinner like we do with code scanning.

This probably needs to shift to an imperative call to a new yaspin instance instead of using with yaspin() so we have more control over the loading indicator.

ericrallen · 2023-10-10T00:41:09Z

interpreter/cli/cli.py

-import subprocess
 import os
-import platform
 import pkg_resources
 import appdirs
-from ..utils.display_markdown_message import display_markdown_message


Cleaning up imports that are no longer needed due to the open_file utility, and removing display_markdown_message as it is no longer used in this file.

ericrallen · 2023-10-10T00:46:34Z

Would love any ideas, suggestions, or assistance getting the edited code block to render as a syntax highlighted code block and ask the user for confirmation before executing.

ericrallen · 2023-10-10T05:40:29Z

interpreter/utils/edit_code.py

+ try:
+ print(" Press `ENTER` after you've saved your edits.")
+
+ open_file(temp_file)


Ideally, eventually we'll be able to incorporate some sort of in-place editing that feels nice, but for the proof of concept, it seemed more prudent to leverage the user's existing default editor.

sbendary25 · 2023-12-12T23:04:00Z

@ericrallen think i figured this out but might have botched the push to git. will tag u in my PR

6rz6 · 2024-04-19T18:30:56Z

I can help with that,

Working on updating the local LLM docs with my latest changes and a full detailed tutorial. once done let me take a look and
solve the issue, are, just verifying, before jumping in, are you working with Verbose on an using it on both open-interpreter and
Litellm open side by side? using break points also in Litellm? and catching events?

✅i hope the answer is yes,

because otherwise,even when you run only Op-In you clearly see the white output of Opin with the prefix and suffix to the user system prompt and then you see a green block of code, that is the forwarding of Litellm after phrasing a little the system message again before retrieving it back to Op-In.

❌If no and last sync was 5 months ago first better re-sync ♻ the branch

I will submit a pull request soon for the docs and one get your feedback can sync pull newer files, and fix the intervention in the system prompt manually, in my case i need just to remove the word 'prompt' which is pushed to the system file among other chat related data and the LOGs.

If we are 5 months behind commits, no use investing in this version unless there is something i'm not aware of with main pull IMO better checkout / pull request the newest version and solve it with a 'man in the middle' as i did with integration
of llamma.cpp :

@BellaBijl wdyt?

CC ->(@sbendary25 @ericrallen @Notnaton ) -> feedback would be highly welcome

ericrallen commented Oct 10, 2023

View reviewed changes

feat: allow editing of code blocks before execution

4401368

ericrallen force-pushed the feature/edit-code branch from 0be3623 to 4401368 Compare October 10, 2023 00:40

ericrallen commented Oct 10, 2023

View reviewed changes

ericrallen mentioned this pull request Oct 10, 2023

editing config while in > OI #578

Closed

ericrallen added Enhancement New feature or request External This Issue is related to an external dependency and not Open Interpreter's core labels Oct 30, 2023

ericrallen closed this Oct 30, 2023

ericrallen reopened this Oct 30, 2023

ericrallen added Help Required Extra attention is needed and removed Enhancement New feature or request External This Issue is related to an external dependency and not Open Interpreter's core labels Oct 30, 2023

Notnaton mentioned this pull request Nov 19, 2023

extra option: or would you like me to regenerate this code? #776

Closed

sbendary25 mentioned this pull request Dec 12, 2023

Feature/edit code #830

Open

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] feat: allow editing of code blocks before execution #612

[WIP] feat: allow editing of code blocks before execution #612

ericrallen commented Oct 10, 2023 •

edited

ericrallen Oct 10, 2023

ericrallen Oct 10, 2023

ericrallen Oct 10, 2023

ericrallen Oct 10, 2023

ericrallen Oct 10, 2023

BellaBijl Mar 30, 2024

ericrallen commented Oct 10, 2023

ericrallen Oct 10, 2023

sbendary25 commented Dec 12, 2023

6rz6 commented Apr 19, 2024


		open_file(temp_file)

		with yaspin(text=f" Editing {language_name} code...").green.right.dots as loading:

[WIP] feat: allow editing of code blocks before execution #612

Are you sure you want to change the base?

[WIP] feat: allow editing of code blocks before execution #612

Conversation

ericrallen commented Oct 10, 2023 • edited

Describe the changes you have made:

Demo

Testing Instructions

Reference any relevant issue (Fixes #537)

I have tested the code on the following OS:

AI Language Model (if applicable)

ericrallen Oct 10, 2023

Choose a reason for hiding this comment

ericrallen Oct 10, 2023

Choose a reason for hiding this comment

ericrallen Oct 10, 2023

Choose a reason for hiding this comment

ericrallen Oct 10, 2023

Choose a reason for hiding this comment

ericrallen Oct 10, 2023

Choose a reason for hiding this comment

BellaBijl Mar 30, 2024

Choose a reason for hiding this comment

ericrallen commented Oct 10, 2023

ericrallen Oct 10, 2023

Choose a reason for hiding this comment

sbendary25 commented Dec 12, 2023

6rz6 commented Apr 19, 2024

ericrallen commented Oct 10, 2023 •

edited