Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for passing query parameter to procedure search #542

Closed
wants to merge 0 commits into from

Conversation

mocy
Copy link
Contributor

@mocy mocy commented Sep 28, 2023

Describe the changes you have made:

The query parameter was not passed properly to the open procedures search. It needs to be converted to a string to be properly URL encoded, and requests.get need to be called with params= (not json=)

I've debug and tested that it provide results that seem to make sense (eg. searching for email return related procedures. youtube seems to be returning relevant procedures). I'm unclear if passing the message in open_ai_messages is the best format to get results from this API end-point.

I wanted to keep the change to a minimum. But it might be nice to do better error handling here. It would be also really nice not to have to go to a remote server (but do the embedding search locally).

Reference any relevant issue (Fixes #000)

  • [ x] I have performed a self-review of my code:

I have tested the code on the following OS:

  • Windows
  • [ x] MacOS
  • Linux

AI Language Model (if applicable)

  • GPT4
  • GPT3
  • Llama 7B
  • Llama 13B
  • Llama 34B
  • Huggingface model (Please specify which one)

@mocy mocy closed this Oct 13, 2023
@mocy mocy force-pushed the fix_rag_procedure_search branch from 2e13a83 to 4c06964 Compare October 13, 2023 04:25
@mocy mocy deleted the fix_rag_procedure_search branch October 13, 2023 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant