Night mode added #67
Open
Night mode added #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdiChat
reviewed
Mar 5, 2018
code/js/popup.js
Outdated
| @@ -154,9 +158,9 @@ function dumpBookmarks(query) | |||
| { | |||
|
|
|||
| if(!favs.includes(fname)) { | |||
| inside_text = inside_text + "<a target='_blank' href='/code/"+key+"/"+obj[key][dd]+"'>"+sub_result_number+". "+obj[key][dd]+"</a>"+" <i id='myStar"+temp2+"\' class='fa fa-star'></i><br>"; | |||
| inside_text = inside_text + "<a target='_blank' id='myId"+temp+"' href='javascript:void(0)'>"+sub_result_number+". "+obj[key][dd]+"</a>"+" <i id='myStar"+temp2+"\' class='fa fa-star'></i><br>"; | |||
There was a problem hiding this comment.
The links are not working. Kindly take a look.
|
You may change the colour of links from blue to white with bold text (like the one is the one in the number of results div). Additionally, while I was reviewing, the links in code results are not working (it is working in the favorites section) and could not see the codes opening in a new tab in night mode in action. Let me know if I might be missing something. Kindly take a look into this. |
|
@AdiChat I have made the corresponding changes. Kindly have a look and share your opinion on it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue:
#63
Changes:
A button called 'Dark Mode' has been added, as shown:
After clicking on which
1) the UI gets changed
2) 'Dark Mode' button is changed to 'Light Mode'
All the colors have been selected after thorough research which decreases the eye strain. The color scheme is best suited for situations when the user is working in the dark.
Kindly review the changes made and give suggestions if required.
UPDATE 1: In commit #bce643a, the night mode feature is extended to the codes being opened up in a new tab as shown:
UPDATE 2: In commit #307dedc, a bug of opening multiple files with a single click was rectified, which was occurring due to some unneeded statement in the code. Also, unnecessary comments were removed.