Add search button #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added search buttton - fixed footer issue - changed UI a little
- Search button added - Footer issues fixed - UI improvised
- Added search button - Fixed footer issue - Header Changed a little
AdiChat
reviewed
Feb 24, 2018
| @@ -9,6 +9,7 @@ | |||
| <link rel="stylesheet" type="text/css" href="css/font.css"> | |||
| <link rel="stylesheet" type="text/css" href="css/fontawesome-all.min.css"> | |||
| <link rel="shortcut icon" type="image/png" href="/icon/icon.png"/> | |||
| <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.css"> | |||
There was a problem hiding this comment.
We can link only to local resources as this extension is intended to work offline. We are using fontawesome-all.min.css, so, you may consider using this as we must consider the size of our extension as well.
|
The UI looks good. 👍 I have added a comment regarding a small change. Kindly review it and make corresponding changes. |
|
Yes okay. ^_^
…On 24 Feb 2018 8:02 pm, "Aditya Chatterjee" ***@***.***> wrote:
The UI looks good. 👍
I have added a comment regarding a small change. Kindly review it and make
corresponding changes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#39 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AblVVuN8ybrLuZ0kHPSCLNDuvdkglnUlks5tYB2AgaJpZM4SMSi7>
.
|
|
Some things got messed up hence created a separate PR. So I am closing this one. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue:
[#31]
Changes: