Skip to content

Commit

Permalink
Back to SNAPSHOT dev cycle
Browse files Browse the repository at this point in the history
  • Loading branch information
oharsta committed Oct 18, 2024
1 parent 5b2c649 commit 49450c7
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 3 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ results.log
notes.txt
Stateless.txt
dependency.tree
OPEN_ID_VC.md
22 changes: 22 additions & 0 deletions OPEN_ID_VC.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
Dynamic Client Registration
What are the requirements for open client registration?

Credential Type Design
Verifiable credential claimset for a SURFconext user with a credentialSubject


Credential Metadata
/.well-known/openid-credential-issuer

Credential Request endpoint
Separate Resource Server?
Wallet Initiated Flow
https://curity.io/resources/learn/verifiable-credentials-issuance/

Issuer Initiated Flow



OAuth 2.0 Assisted Token
https://www.ietf.org/archive/id/draft-ideskog-assisted-token-05.html

2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

<groupId>org.openconext</groupId>
<artifactId>oidcng</artifactId>
<version>6.1.15</version>
<version>6.1.16-SNAPSHOT</version>
<name>oidcng</name>

<dependencyManagement>
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/oidc/endpoints/AuthorizationEndpoint.java
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ private ModelAndView doAuthorization(MultiValueMap<String, String> parameters,

if (scope != null) {
List<String> scopeList = scope.toStringList();
boolean apiScopeRequested = !(scopeList.size() == 0 || (scopeList.size() == 1 && scopeList.contains("openid")));
boolean apiScopeRequested = !(scopeList.isEmpty() || (scopeList.size() == 1 && scopeList.contains("openid")));
Set<String> filteredScopes = scopeList.stream()
.filter(s -> !s.equalsIgnoreCase("openid"))
.map(String::toLowerCase)
Expand All @@ -169,7 +169,7 @@ private ModelAndView doAuthorization(MultiValueMap<String, String> parameters,
* Manage attribute "oidc:consentRequired" is true for the RP or the RP has explicitly asked for consent
* There is at least one ResourceServer that has the requested scope(s) configured in manage
*/
if (consentRequired && apiScopeRequested && (consentFromPrompt || client.isConsentRequired()) && resourceServers.size() > 0) {
if (consentRequired && apiScopeRequested && (consentFromPrompt || client.isConsentRequired()) && !resourceServers.isEmpty()) {
LOG.info("Asking for consent for User " + user + " and scopes " + scopes);
return doConsent(parameters, client, filteredScopes, resourceServers, state);
}
Expand Down

0 comments on commit 49450c7

Please sign in to comment.