GetWithRelationship(s) conveniences #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feltech
requested changes
May 14, 2024
Yeah no doubt. I spent forever splatting them but was absolutely sure there were gonna be more. In fact, I sort of think I may have made it worse in some of my attempts to be consistent. Should likely have split GetWithRelationship() and GetWithRelationships() up into different commits and worked on them separately, the reason I didn't was cause of the GIL tests, didn't want failing tests, but also didnt want to comment out the check to remind me to implement the other formulation. This is a silly reason and easily worked around. |
feltech
reviewed
May 16, 2024
feltech
requested changes
May 20, 2024
Conveniences for exceptional and variant based error-object modes for the GetWithRelationship(s) methods, for both singular and batch variations. Signed-off-by: Elliot Morris <[email protected]>
elliotcmorris
force-pushed
the
work/973-conveniences-relationships
branch
from
7f29e50
to
74685f0
Compare
feltech
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #973
Adds standard set of singular/batch conveniences for getWithRelationship(s), for both exceptional and variant error modalities.
Due to the inability to use the test framework for conveniences, it's all a bit rough & ready. I'm hoping just a happy path and a failure case are enough considering the scope of duplication involved.
Reviewer Notes
Docs are in another commit. Just sort of worked out this way but I thought it's probably a better reviewer experience so left it like that. Will squash after.
Good luck trying to keep all the variations strait in your head when looking at docs & bindings ... I really struggled.