Development #609
Open
Development #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required since the minimum SDK is less than 27 where it became the default
This reverts commit 345ce00. Meant to make a PR before merging to development.
Required since the minimum SDK is less than 27 where it became the default
fix(ci): just make circle ci pass for now
…ext-traffic fix(network config): restrict clear text by default #541
make use of compatibility helpers
Bugs: include preconditions, actual behaviour, and more environment details Features: add alternate template for user story format Fastlane: use local ENV vars, remove slack and prepare for alpha/beta/internal uploads
fix(localization): typo in google drive string
…stered-receivier-api fix(tor): ensure registered recievers are not exported in android 14+
…re-error fix(upload): use generic error message
… specifications. These thwart Android Studio's update helpers. Added deprecation warnings as per Kotlin update analysis.
…emplates chore(project): update issue templates and fastlane
make use of compatibility helpers
… specifications. These thwart Android Studio's update helpers. Added deprecation warnings as per Kotlin update analysis.
Bugs: include preconditions, actual behaviour, and more environment details Features: add alternate template for user story format Fastlane: use local ENV vars, remove slack and prepare for alpha/beta/internal uploads
…roid 14+" This reverts commit 32124f3.
The root problem is the '/' separator is being url encoded and not sa url path.
…roid 14+" This reverts commit 32124f3.
the device reported is 74mm wide which is around 466dp. use a vertical orientation by default and anything greater than 466dp use a horizontal orientation. tested on small and medium emulators. Such a good use case for jetpack compose.
upload metadata and proofs async while still tracking errors
- pass progress to broadcast without model save - make sure gson is excluding fields from IA metadata
Conflicts: app/src/main/java/net/opendasharchive/openarchive/services/SaveClient.kt app/src/main/java/net/opendasharchive/openarchive/services/internetarchive/IaConduit.kt
Conflicts: app/src/main/java/net/opendasharchive/openarchive/features/main/MainMediaFragment.kt app/src/main/java/net/opendasharchive/openarchive/services/internetarchive/IaConduit.kt
#495 a simpler internet archive
receiver save internet archive identifiers as the media server url (not a part of meta data) ensure cancelled uploads are saved to prevent new file identifiers ensure upload service coroutine scopes are cancelled on job cancel
fix(welcome): add arrow svg to match design
fix(upload manager): ensure main thread interactions from broadcast receiver
|
Hi Richard,
I have gone through the ticket but I think this is the development ticket.
What should I test in this ticket or do you want me to go through the Save
App in general and see if anything is broken?
Best Regards
Purvi
…On Thu, May 23, 2024 at 9:04 PM Richard Puckett ***@***.***> wrote:
@rapuckett <https://github.com/rapuckett> requested your review on: #609
<#609> Development.
—
Reply to this email directly, view it on GitHub
<#609 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB6PRPJYKCHTOGNIXKKRI2TZDYEBNAVCNFSM6AAAAABIF5BVXOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSHEYTCNBTHEYTINQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
--
Regards
Purvi
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs comprehensive review due to amount of changes