[BUG][KOTLIN] Refactor type mappings to map types into simple class names #20018
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up pr for #19981 and bug #19942.
During the initial fix preparation, I discovered that even though DefaultCodegen and other language codegens (i.e. java) expect the mapped type in
typeMapping
to be a simple class name, kotlin codegens are putting canonical names in there.Then, the
{{dataType}}
model param is eventually resolved to the canionical name, whereas it is expected to be a simple class name.This situation can lead to the compilation errors from the generated code in the worst case scenario.
This PR aims to fix this issue by changing
typeMapping
to simple class names and introducingimportMapping
whenever the canionical name is required in the imports.For convenience, the PR contains 2 commits. The first one contains all the code changes, whereas the second one is mostly the regenerated samples.
Technical Kotlin Committee:
@dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m @stefankoppier @e5l
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)