Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust-reqwest]: group operations into structs #18636

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

maxnachlinger
Copy link
Contributor

@maxnachlinger maxnachlinger commented May 10, 2024

Fixes: #18637

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @frol (2017/07) @farcaller (2017/08) @richardwhiuk (2019/07) @paladinzh (2020/05) @jacob-pro (2022/10)

@maxnachlinger maxnachlinger changed the title Chore group operations into structs rust: group operations into structs May 10, 2024
Comment on lines +26 to +28
pub struct DefaultApi;

let local_var_client = &local_var_configuration.client;
impl DefaultApi {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change groups the operations against, in this case, the DefaultApi into a DefaultApi struct for organizational purposes.

Comment on lines +74 to +76
pub struct {{{classname}}};

impl {{{classname}}} {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a preference for sure :) For my part I find Rust code easier to maintain when it is grouped into meaningful structs. I would also be happy to add a feature to control this grouping behavior if we'd like to go that direction.

@maxnachlinger maxnachlinger marked this pull request as ready for review May 10, 2024 23:16
@maxnachlinger maxnachlinger changed the title rust: group operations into structs [rust-reqwest]: group operations into structs May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] rust: group operations into structs
1 participant