Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to fix CI by upgrading kotlin-dsl #18634

Closed
wants to merge 2 commits into from

Conversation

ctreatma
Copy link
Contributor

CI started failing recently due to an issue in a compileKotlin task.

This PR updates kotlin-dsl to a newer version based on this line of job output: https://app.travis-ci.com/github/OpenAPITools/openapi-generator/jobs/621489729#L10026

I have not been able to replicate the CI failure locally, so I'm not confident that this will actually fix the issue.

If I'm reading the CI job configuration correctly, the command that is failing is:

./mvnw -e --no-snapshot-updates --quiet --batch-mode --show-version clean install -DskipTests -Dmaven.javadoc.skip=true -Dorg.slf4j.simpleLogger.defaultLogLevel=error

That command passes on my local machine (M1 Mac using Temurin JDK 11).

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@ctreatma
Copy link
Contributor Author

This PR is an attempt to address the issue raised in this comment: #18436 (comment)

@wing328
Copy link
Member

wing328 commented May 11, 2024

i've pushed some fixes (mainly reverting gradle wrapper to 7,6.4) and now the build passes

@wing328 wing328 closed this May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants