fix(#758): add path.join to build os-dependent java binary path #759
Conversation
| .filter(isString) | ||
| .join(' '); | ||
|
|
||
| return this.isWin() ? `"${command}"` : command; |
There was a problem hiding this comment.
the generated commands already have " inside and only run successfully with these quotes in the windows build and without it will not.
concurrently expects it in this case if there are spaces in the paths, which is very common in windows. therefore i would generalize this.
i was also been able to reproduce the behavior with concurrently alone.
i can send later some examples.
the most important part of the windows build plan already looks promising. there is only one error in the last step that i can't get locally.
Error: spawn ENAMETOOLONG
sounds really special to me. i think the command is too long. i try to figure out why this is. i mean foo is not longer then bar 😂
There was a problem hiding this comment.
i got it. i removed the JAVA_HOME env wrong. for now all tests are passed.
can you tell me how i can resolve the conflicts? why does this not behave like the first PR, where i was able to resolve the conflicts?
There was a problem hiding this comment.
you will need to cherry-pick 3e949d8, which was reverted by me last week.
There was a problem hiding this comment.
the generated commands already have " inside and only run successfully with these quotes in the windows build and without it will not.
did you test with something like --additional-properties option="test-double-quote" ?
There was a problem hiding this comment.
i tried to cherry-pick but after resolving the conflicts there was nothing to commit. i commited with git commit --allow-empty but it will not resolve the conflicts.
did you test with something like --additional-properties option="test-double-quote" ?
i try to implement something like this to the test.
on my local env (windows - git bash) the following succeeded:
$ npm run oa generate -- -g ruby -i https://raw.githubusercontent.com/OpenAPITools/openapi-generator/master/modules/openapi-generator/src/test/resources/3_0/petstore.yaml -o ./out/ruby --additional-properties option="test-double-quote"
> [email protected] oa
> openapi-generator-cli generate -g ruby -i https://raw.githubusercontent.com/OpenAPITools/openapi-generator/master/modules/openapi-generator/src/test/resources/3_0/petstore.yaml -o ./out/ruby --additional-properties option=test-double-quote
[main] INFO o.o.codegen.DefaultGenerator - Generating with dryRun=false
[main] INFO o.o.codegen.DefaultGenerator - OpenAPI Generator: ruby (client)
[main] INFO o.o.codegen.DefaultGenerator - Generator 'ruby' is considered stable.
...
$ echo $?
0Feature/add windows to build
* support JAVA_HOME environment variable fixes OpenAPITools#661 * test(generator-cmd): add consideration of the JAVA_HOME variable * docs: add instructions for the use of JAVA_HOME * fix: add quotes to accept spaces in the JAVA_HOME path * fix: add quotation marks only for windows paths --------- Co-authored-by: Nils Braune <[email protected]>
fixes #758