Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom templates #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dotxoa
Copy link

@dotxoa dotxoa commented Apr 7, 2023

It tries to solve this issue.

I have doubts about how to get the template folder path in the right way. Right now I am picking the first file of the folder and the get its path, but this will fail in the case that the folder is empty.

https://github.com/OpenAPITools/openapi-generator-bazel/pull/40/files#diff-c1d432311512e669de77c6dfc7da138be54d44e9646442e1d223e9a4a138ab5cR73

@dotxoa
Copy link
Author

dotxoa commented Apr 10, 2023

@wing328 can you take a look to this?

@wing328
Copy link
Member

wing328 commented Apr 12, 2023

thanks for the PR 👍

Can you please PM me via Slack when you've time to have a quick chat (IM) on this?

https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

@wing328
Copy link
Member

wing328 commented Apr 12, 2023

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants