Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM upgrade incl. webpack 5 #765

Merged
merged 12 commits into from
Apr 8, 2024
Merged

NPM upgrade incl. webpack 5 #765

merged 12 commits into from
Apr 8, 2024

Conversation

lentinj
Copy link
Collaborator

@lentinj lentinj commented Mar 15, 2024

Upgrade everything in NPM land, in particular webpack 5

Needs way more testing, and solving sass deprecations, but basically works.

I'll try with a new onezoom container when I get a chance to rebuild.

@lentinj
Copy link
Collaborator Author

lentinj commented Mar 15, 2024

Also worth noting that a handful of packages only support NPM 18. I've changed the readme in the above, but we should probably be sure that there isn't anything left on NPM 16 before merging.

This is bootstrap code, not ours, but we're unlikely to upgrade it.
"Use Legacy Authentication" isn't necessary thanks to the venv

--legacy-peer-deps isn't necessary thanks to the webpack 5 upgrade.
Add location block that can be used to proxy to a development instance
instead of uwsgi
"grunt start-dev" is problematic, due to grunt's mangling of stdin/out.
Instead allow web2py-run to start web2py.
@hyanwong
Copy link
Member

Great, thanks for this @lentinj : great to keep on top of it all.

@lentinj lentinj marked this pull request as ready for review March 26, 2024 09:44
@lentinj
Copy link
Collaborator Author

lentinj commented Mar 26, 2024

@hyanwong Everything here seems to work fine in a fresh Ubuntu 22.04 container, so this could be merged I think.

The Node 18 requirement should be fine with the new servers, but might be worth checking it builds fine on beta first before merging.

@lentinj
Copy link
Collaborator Author

lentinj commented Mar 26, 2024

And as a bonus, the clientside CI pipeline now also makes sure the webpack build succeeds. Day-to-day this is a bit too low of a bar, but will be interesting for dependabot reports.

@hyanwong
Copy link
Member

Great. I will check it builds on beta an then merge. Thanks a lot @lentinj !

@hyanwong hyanwong merged commit b916c72 into main Apr 8, 2024
1 check passed
@lentinj lentinj mentioned this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants