Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix polytomy bounding box calculation. #706

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wolfmanstout
Copy link
Contributor

Caused numerical instability when zooming deep (e.g. Citrus reticulata) due to bad choice of graphref.

@wolfmanstout
Copy link
Contributor Author

Using onezoom.config.debug_bounding_box = 0x01 ...

Before: boxes_before
After: boxes_after

@lentinj
Copy link
Collaborator

lentinj commented Jan 23, 2024

This is approximately undoing 3bc42f5 - did you pull the thread to see we can rely on node.upnode.arcr now?

This might have been solved in the interim, I can't remember off the top of my head so would have to have a rummage.

@wolfmanstout
Copy link
Contributor Author

Good question, I can check later.

@wolfmanstout
Copy link
Contributor Author

Reverting 3bc42f5 causes the same problems as initially noted in that commit. At first I thought it was working well, but if I reloaded the page after going to sea cucumbers and then zoomed out with bounding boxes enabled, I could see large bounding boxes when I zoomed out that would eventually disappear. I do not see this issue with this PR.

…hen zooming deep (e.g. Citrus reticulata) due to bad choice of graphref.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants