MSFT_PackageManagement: Fix passing switch values in AdditionalParameters #500
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a DSC configuration, which uses the
PackageManagement
resource and attempts to pass provider-specific parameters viaAdditionalParameters
, is compiled, the parameters dictionary is serialized toMSFT_KeyValuePair
objects, which hold a pair of strings. As a consequence, all type information aboutAdditionalParameters
values is lost.This poses a problem when a provider defines parameters whose types are not implictly convertible from string. Two such common types are
[switch]
and[bool]
. For example, thePowerShellGet
provider defines several switch parameters, such asInstallUpdate
,AllowClobber
orAllowPrereleaseVersions
- all of those are quite important. Unfortunately, attempting to pass values to those parameters in a DSC configuration leads to failures, caused by attempts to directly assign a string value to aSwitchParameter
.This pull request solves this problem. Although the
PackageManagement
resource has no direct access to provider metadata, it can examine the parameters of the cmdlets it intends to call and determine their types. For[switch]
and[bool]
parameters, the resource parses the string value fromAdditionalParameters
to a[bool]
, which is implicitly convertible to[switch]
.Example configuration, which fails on 1.4.7 and works after this PR: