Remove LOWER for pgsql driver because it's redundant #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because you're forcing ILIKE when using the pgsql driver, you only need to cast to text and not lower. Lowering clobbers all indexes, making it impossible to improve query speeds. The below ILIKE when using pgsql takes care of lower and upper searches while still leaving the cast above for dates etc.
|
Thanks for you PR, could you please pull the master and fix failing tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because you're forcing ILIKE when using the pgsql driver, you only need to cast to text and not lower. Lowering clobbers all indexes, making it impossible to improve query speeds. The below ILIKE when using pgsql takes care of lower and upper searches while still leaving the cast above for dates etc.