🐛 Achievements: Fix a bug in achievement count display

OctoPrint · Jan 31, 2024 · f1e7f32 · f1e7f32
1 parent 6ae8822
commit f1e7f32
Showing 1 changed file with 6 additions and 13 deletions.
diff --git a/src/octoprint/plugins/achievements/static/js/achievements.js b/src/octoprint/plugins/achievements/static/js/achievements.js
@@ -91,21 +91,14 @@ $(function () {
  self.fromStatsResponse(response.stats);
  self.fromAchievementsResponse(response.achievements);
 
- let hidden = response.hidden_achievements;
- let achieved = 0;
- let achievedHidden = 0;
- _.each(self.achievements(), (achievement) => {
- if (achievement.achieved) {
- achieved++;
- if (achievement.hidden) {
- achievedHidden++;
- }
- }
- });
+ const achieved = _.filter(
+ self.achievements(),
+ (achievement) => achievement.achieved
+ ).length;
  self.achievedAchievements(achieved);
- self.hiddenAchievements(hidden - achievedHidden);
+ self.hiddenAchievements(response.hidden_achievements);
  self.totalAchievements(
- self.achievements().length + self.hiddenAchievements()
+ response.achievements.length + response.hidden_achievements
  );
  };