Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Paket #1047

Closed
wants to merge 0 commits into from
Closed

Add support for Paket #1047

wants to merge 0 commits into from

Conversation

xt0rted
Copy link
Member

@xt0rted xt0rted commented Oct 2, 2020

Pull Request Badge

Checklist:

  • If this PR is a new feature, please provide at least one example link
  • Make sure all of the significant new logic is covered by tests

This adds support for the f#/.net package manager Paket. I didn't add support for paket.lock files because we don't really support them for other environments.

Example files used when building this out:

.editorconfig Outdated
Comment on lines 14 to 15
[*.js]
end_of_line = lf
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of my files have been using CrLf. The setting in .gitattributes doesn't cover new files so I think VS Code's been using the system default which this will fix.

@xt0rted
Copy link
Member Author

xt0rted commented Oct 2, 2020

@stefanbuck for some reason a bunch of unrelated tests keep failing on this and #1035

@xt0rted xt0rted marked this pull request as ready for review October 2, 2020 05:09
@stefanbuck
Copy link
Member

From what I can tell, tests are failing because your branch is behind the main branch by 22 commits. All failing tests are related to recently added features like css and PHP which are missing on your branch. Still confusing, because the config for E2E tests is generated on the fly by walking through the fixtures folder.

@stefanbuck
Copy link
Member

Ohh looks like the checkout step is doing a merge https://github.com/OctoLinker/OctoLinker/pull/1047/checks?check_run_id=1200633923#step:3:357 I'm going to rebase your branch to verify my assumption

@stefanbuck
Copy link
Member

Oh dear, something went wrong while rebasing. @xt0rted please rebase and push the branch again. Sorry for the mess

@xt0rted xt0rted mentioned this pull request Oct 6, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants