Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OHI-1538] fix(icons): icons missing for volume presets and others #4671

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IbrahimCSAE
Copy link
Collaborator

@IbrahimCSAE IbrahimCSAE commented Jan 10, 2025

Context

Fixes some icons that were not being display due to small name differences, or just being missing after the migration.

CleanShot 2025-01-09 at 23 52 04@2x

CleanShot 2025-01-09 at 23 52 34@2x

Closes #4652
Closes OHI-1538

@IbrahimCSAE IbrahimCSAE requested a review from sedghi January 10, 2025 04:51
Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 87b62b4
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/6780a7549f74d90008f03548
😎 Deploy Preview https://deploy-preview-4671--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 87b62b4
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/6780a7540e265b0008ca9c1a
😎 Deploy Preview https://deploy-preview-4671--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Jan 10, 2025

Viewers    Run #4659

Run Properties:  status check passed Passed #4659  •  git commit 87b62b45ce: fix icon issues
Project Viewers
Branch Review fix/missing-icons
Run status status check passed Passed #4659
Run duration 02m 06s
Commit git commit 87b62b45ce: fix icon issues
Committer Ibrahim
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 44
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Missing Icons
1 participant