Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui) Feature components in ui-next grouped and renamed #4640

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dan-rukas
Copy link
Member

Context

Grouped related feature components (unique or single-use components) in ui-next and updated how they are imported in the application. This consolidation provides a clearer architectural layout for domain and feature-specific components, making them easier to maintain and expand in future releases.

In addition, this naming helps to separate any feature components from core reusable Design System components. Additional PRs will be submitted for components moving from the legacy ui component library to the ui-next component library, ensuring a consistent modernization path.

Changes & Results

OHIF Data Lists

  • Moved SegmentationTable to OHIFSegmentationTable along with subcomponents
  • Moved MeasurementTable to OHIFMeasurementTable
  • All Components are now loacated in /ui-next/src/components/OHIFDataLists

OHIF Header

  • Moved Header to OHIFHeader
  • Moved NavBar
  • All Components are now loacated in /ui-next/src/components/OHIFHeader

OHIF Study Browser

  • Moved DisplayMessageSet to OHIFDisplayMessageSet
  • Moved StudyBrowser to OHIFStudyBrowser
  • Moved StudyBrowserSort to OHIFStudyBrowserSort
  • Moved StudyBrowserViewOptions to OHIFStudyBrowserViewOptions
  • Moved StudyItem to OHIFStudyItem
  • Moved StudySummary to OHIFStudySummary
  • Moved Thumbnail to OHIFThumbnail
  • Moved ThumbnailList to OHIFThumbnailList
  • All Components are now located in /ui-next/src/components/OHIFStudyBrowser

Testing

Checklist

PR

  • [✅] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [✅] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [✅] OS: macOS Sequoia 15.2, M4 Pro
  • [✅] Node version: v23.5.0
  • [✅] Browser: Chrome 131.0.6778.205 (Official Build) (arm64)

Each component now lives in the OHIFStudyBrowser folder in ui-next
Moved, renamed, and updated App files to use new imports from ui-next
Renamed to OHIFSegmentationTable and OHIFMeasurementTable. Updated imports and Application usage
Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit a8f1cdb
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/677719530d5b8a0008f99b98
😎 Deploy Preview https://deploy-preview-4640--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit a8f1cdb
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/67771953f5b3ac0008954380
😎 Deploy Preview https://deploy-preview-4640--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant