Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Integrate CustomizationService with UiDialogService and support customized components in Annotation Labelling #4634

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

abhijith-trenser
Copy link
Contributor

@abhijith-trenser abhijith-trenser commented Dec 30, 2024

Context

  • Integrated customizationService to uiDialogservice globally through DialogProvider.
  • Implemented support for using custom component for Annotation Labelling through customizationService.
  • This PR has been incorporated by FlyWheel.io

Changes & Results

  • To use the CustomizationService in DialogService, pass the CustomizationService through the DialogProvider in App.tsx to ensure it is globally available for the UI Dialog Service.
  • For customization in the Annotation labeling component (LabelFlow), added support for using a component received through the CustomizationService with the ID "measurement.labellingComponent." If not provided, the default component will be used.

Testing

  1. Introduce a new customization method with a custom annotation labeling component (id:measurement.labellingComponent).
  2. Launch a study.
  3. Draw an annotation.
  4. Edit the annotation label.
  5. Instead of the default UI, the viewer will render the customized component provided.

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: Windows 10
  • Node version: 18.19.0
  • Browser: Chrome 131.0.6778.205

…port for custom annotation labelling component
Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 3917c65
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/677e04387f2ff40008cc1559
😎 Deploy Preview https://deploy-preview-4634--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 3917c65
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/677e04382c513b00085f6d30
😎 Deploy Preview https://deploy-preview-4634--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi
Copy link
Member

sedghi commented Jan 8, 2025

we are reworking the customizationService so stay tuned until it is done

@abhijith-trenser
Copy link
Contributor Author

we are reworking the customizationService so stay tuned until it is done

Thank you for the information, @sedghi. Would you happen to have a feature branch or work item that could serve as a reference for the implementation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants