fix: Having sop instance in a per-frame or shared attribute breaks load #4560
+51
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-dev canceled.
|
wayfarer3130
commented
Nov 29, 2024
| // During a resize, the slice index should remain unchanged. This is a temporary fix for | ||
| // a larger issue regarding the definition of slice index with slab thickness. | ||
| // We need to revisit this to make it more robust and understandable. | ||
| delete presentation.viewReference.sliceIndex; | ||
| if (presentation?.viewReference) { |
There was a problem hiding this comment.
This is still an issue entering MPR mode, but at least it doesn't throw
wayfarer3130
commented
Nov 29, 2024
Viewers
|
||||||||||||||||||||||||||||
| Project |
Viewers
|
| Branch Review |
fix/sop-instance-in-per-frame
|
| Run status |
|
| Run duration | 02m 21s |
| Commit |
|
| Committer | Bill Wallace |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
44
|
| View all changes introduced in this branch ↗︎ | |
sedghi
requested changes
Nov 29, 2024
|
@wayfarer3130 can you upload an anonymized study that does not work right now or bug report issue number |
|
@sedghi - could you check the uploaded study? That study works correctly now, but I don't understand why your MPR issue breaks. I tried looking at that, but if you could help debug that with me sometime I'd appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aent### Context
Some PACS systems combine single frame into multi-frame and then record the original SOPInstanceUID in the per frame attribute sequence. This PR simply omits such per frame instances.
Changes & Results
Uses a shared object for the parent series/instance data rather than merging, and avoid over-riding anything containing a SOP instance UID.
This addresses #4551
It also addresses the issue from Jagan Vijayaraghavan in slack, for which he provided the study below.
StudyWithSOPInFrameSequence.zip
The issue is that a shared functional groups sequence contains an original SOP instance UID for another object, and that SOP ends up replacing the correct SOP/Series UIDs, causing the wrong UIDs to be used.
Testing
Load the study with the per-frame data from the cornerstone chat
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment