Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support cycling rotateViewportCCW #4533

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

tunglt1810
Copy link

support negative rotation value

Context

  • command rotateViewport does not work when calculated rotation value is negative

Changes & Results

  • add logic to make rotation value is always positive

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: macOS 15.1.1
  • Node version: 18.16.1
  • Browser: Chrom 131.0.6778.70 (Official Build) (arm64)

support negative rotation value
Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for ohif-dev canceled.

Name Link
🔨 Latest commit 699c5de
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/676ce30928646c000890e0ba

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for ohif-platform-docs canceled.

Name Link
🔨 Latest commit 699c5de
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/676ce309df74600008974292

@tunglt1810 tunglt1810 changed the title Update commandsModule.ts support cycling rotateViewportCCW Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants