Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mg split fix #4480

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

mg split fix #4480

wants to merge 1 commit into from

Conversation

narbek-abd
Copy link

@narbek-abd narbek-abd commented Nov 11, 2024

Context

fixes:
#4416
#4239

Changes & Results

before:
#4416 (comment)

after:
https://github-production-user-asset-6210df.s3.amazonaws.com/59279794/375717245-422a988b-daf3-43e4-a96e-b07d272c4889.webm?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAVCODYLSA53PQK4ZA%2F20241111%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20241111T115415Z&X-Amz-Expires=300&X-Amz-Signature=a46e1a2e8b2e3eda55cad54c22b51bbf6cde0d4c6621e74fbc81aa8c8d9dcaf2&X-Amz-SignedHeaders=host

Testing

We have a lot of mammo studies and it works good

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 516bd63
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/6731f0e4ab9eaf0009ba379b
😎 Deploy Preview https://deploy-preview-4480--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 516bd63
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/6731f0e50c4b630008852509
😎 Deploy Preview https://deploy-preview-4480--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi
Copy link
Member

sedghi commented Dec 19, 2024

Thanks for the PR. I spoke with my team, and we believe this can be implemented in your extension and mode, so there's no need to push the code upstream to OHIF.

Here is how you can do it

  1. Create an extension (if you don't have one yet)
  2. Create a sopClassHandler
  3. In your mode use it
function modeFactory({ modeConfiguration }) {
  return {
    // rest of the code 
    routes: [
      {
        // rest of the code 
        layoutTemplate: () => {
          return {
            id: ohif.layout,
            props: {
              // rest of the code 
              viewports: [
                {
                  namespace: tracked.viewport,
                  displaySetsToDisplay: [
                    myCustomSopClassHandler,
                    ohif.sopClassHandler,
                    dicomvideo.sopClassHandler,
                    dicomsr.sopClassHandler3D,
                    ohif.wsiSopClassHandler,
                  ],
                },
                 // rest of them
              ],
            },
          };
        },
      },
    ],
    sopClassHandlers: [
      myCustomSopClassHandler,
      dicomvideo.sopClassHandler,
      dicomSeg.sopClassHandler,
      dicomPmap.sopClassHandler,
      ohif.sopClassHandler,
      ohif.wsiSopClassHandler,
      dicompdf.sopClassHandler,
      dicomsr.sopClassHandler3D,
      dicomsr.sopClassHandler,
      dicomRT.sopClassHandler,
    ],
  };
}

Note we are putting them in front of the other sopClassHandlers so that it gets evaluated first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants