CMAKE_CL_64 is deprecated and only works with Microsoft Visual Studio #2922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you rebase this on master? CI is currently failing due to zlib.. |
sercero
force-pushed
the
directx_detect
branch
from
4265911
to
8e2ced1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using
CMAKE_CL_64, we should be usingCMAKE_SIZEOF_VOID_P.In the official CMAKE documentation it says that
CMAKE_CL_64is deprecated (https://cmake.org/cmake/help/latest/variable/CMAKE_CL_64.html)And the 64-bit detection does not work in
MinGW64.