Explain dynamic refs for generics (3.2.0 port of #3714) #3795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handrews
added
schema-object
clarification
handrews
changed the title
lornajane
previously approved these changes
May 14, 2024
ralfhandl
requested changes
May 14, 2024
There was a problem hiding this comment.
- Align YAML with JSON example
- Use consistent YAML formatting identical to Explain that dynamic refs can implement generics #3714
|
@ralfhandl ah, I see what happened here - I auto-ported the fix with |
Includes an example. This intentionally does not explain how dynamic referencing works, as there are better resources available in both the spec and (more readably) the official JSON Schema blog. Thanks to Ralf for review feedback fixes on the original 3.2.0 PR Co-authored-by: Ralf Handl <[email protected]>
|
@ralfhandl I've marked your suggestions as resolved as the rebased force-push I just did should contain all of your corrections from the previous PR (as well as some from other folks). |
ralfhandl
approved these changes
May 15, 2024
|
This had two approvals and the minor fix cleared them - one re-approval from the person who asked for the minor fix is sufficient, so I'll merge this (it's a port, after all). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes an example. This intentionally does not explain how dynamic referencing works, as there are better resources available in both the spec and (more readably) the official JSON Schema blog.