Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scopes process of get_authorization_url #577

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix scopes process of get_authorization_url #577

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion O365/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,12 @@ def get_authorization_url(self, requested_scopes=None,

redirect_uri = redirect_uri or self.oauth_redirect_url

scopes = requested_scopes or self.scopes
if requested_scopes:
protocol = MSGraphProtocol()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't assume here that the protocol in use is MSGraphProtocol.

requested_scopes = protocol.get_scopes_for(requested_scopes)
scopes = requested_scopes
else:
scopes = self.scopes
if not scopes:
raise ValueError('Must provide at least one scope')

Expand Down