issue#508 rudimentary bug fix #512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just realized I should remove the print_single_group and rename print_all_groups and just call that since the groups are being filtered out now. Will do it later today. |
|
This changes only fixes the problem, while removing another feature. I created another MR for this fix over here, which includes tests and incorporates the filter logic into the query.. #513 Could you try and check whether this fixes your problem :)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've never made a pull request for a github repo, this is my first open source contribution and also a rust noob.
That being said what's happening here is that we are using first as the limit but we don't remove the unused groups from the list of tasks so we are grabbing the first task which is from g1 but it won't get printed when it tries to print only the used groups.