fix: make graceful daemon shutdown exit with code 0 #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good point. I'm no longer sure why I let it exit with code 1 to be honest. But I tested for it xD! Exiting with |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #504 +/- ##
===============================================
+ Coverage 80.15% 80.16% +0.01%
===============================================
Files 77 77
Lines 5673 5673
===============================================
+ Hits 4547 4548 +1
+ Misses 1126 1125 -1 ☔ View full report in Codecov by Sentry. |
|
Classic changelog merge conflict -.- I really have to look at automated changelogs at some point. |
When shutting down pueued using SIGINT or SIGTERM then the exit code should be zero. This is necessary, for example, when running as a systemd service since systemd will otherwise put the service in a failed state whenever it shuts down.
|
Cool, thanks! I've rebased the branch with the conflict resolved. |
|
Thanks! |
|
Thank you! I'll have to release a new version soon with these changes :D |
|
That would be great, much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When shutting down pueued using SIGINT or SIGTERM then the exit code should be zero. This is necessary, for example, when running as a systemd service since systemd will otherwise put the service in a failed state whenever it shuts down.
I'm not sure why it is currently exiting with an error-code. Maybe it is for some good reason? But looking at the code comments it definitely mentions exiting gracefully, which I would interpret as exit code 0.
Checklist
CHANGELOG.md.cargo clippyandcargo fmt. The CI will fail otherwise anyway.