Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better pid error messages #467

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Better pid error messages #467

merged 1 commit into from
Oct 5, 2023

Conversation

Nukesor
Copy link
Owner

@Nukesor Nukesor commented Oct 5, 2023

Resolves #466

@Nukesor Nukesor added t: Enhancement Something that exists, but could be made better s: Daemon This issue touches pueue daemon labels Oct 5, 2023
@Nukesor Nukesor self-assigned this Oct 5, 2023
@Nukesor Nukesor changed the base branch from main to development October 5, 2023 18:16
@Nukesor Nukesor force-pushed the better-pid-error-messages branch from 85d5358 to e79818e Compare October 5, 2023 18:20
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2023 •
edited
Loading

Codecov Report

Merging #467 (e79818e) into development (96b5fef) will not change coverage.
The diff coverage is 50.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff              @@
##           development     #467   +/-   ##
============================================
  Coverage        79.78%   79.78%           
============================================
  Files               77       77           
  Lines             5511     5511           
============================================
  Hits              4397     4397           
  Misses            1114     1114
Files Coverage Δ
pueue/src/daemon/task_handler/callback.rs 11.49% <0.00%> (ø)
pueue/src/daemon/pid.rs 42.85% <57.14%> (ø)

... and 1 file with indirect coverage changes

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Test Results

    3 files  ±0    22 suites  ±0   4m 3s ⏱️ + 1m 11s
143 tests ±0  143 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
306 runs  ±0  306 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e79818e. ± Comparison against base commit 96b5fef.

@Nukesor Nukesor merged commit 94ecaaf into development Oct 5, 2023
17 checks passed
@Nukesor Nukesor deleted the better-pid-error-messages branch October 5, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Nukesor Nukesor

Labels
s: Daemon This issue touches pueue daemon t: Enhancement Something that exists, but could be made better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Failed to create pid file
2 participants
@Nukesor @codecov-commenter