Skip to content

Commit

Permalink
fix(lint): Disable cargo-sort for now, as it breaks CI
Browse files Browse the repository at this point in the history
  • Loading branch information
Nukesor committed Nov 23, 2024
1 parent 57e829f commit 22186dd
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,20 +72,20 @@ jobs:
lint-${{ runner.os }}-cargo-${{ matrix.target }}-
${{ runner.os }}-cargo-${{ matrix.target }}-
- name: Install cargo-sort
run: cargo install cargo-sort || exit 0
if: matrix.target != 'x86_64-pc-windows-msvc'

# ----- Actual linting logic ------
# These lines should mirror the `just lint` command.
- name: cargo fmt
run: cargo fmt --all -- --check

- name: cargo sort
run: cargo sort --workspace --check
# Don't run cargo-sort on windows, as the formatting behavior seems to be slightly different:
# https://github.com/DevinR528/cargo-sort/issues/56
if: matrix.target != 'x86_64-pc-windows-msvc'

- name: cargo clippy
run: cargo clippy --tests --workspace -- -D warnings

#- name: cargo sort
# run: cargo sort --workspace --check
# # Don't run cargo-sort on windows, as the formatting behavior seems to be slightly different:
# # https://github.com/DevinR528/cargo-sort/issues/56
# if: matrix.target != 'x86_64-pc-windows-msvc'

#- name: Install cargo-sort
# run: cargo install cargo-sort || exit 0
# if: matrix.target != 'x86_64-pc-windows-msvc'

0 comments on commit 22186dd

Please sign in to comment.