Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve kick message for players without reactor #82

Closed
wants to merge 1 commit into from

Conversation

whichtwix
Copy link

Currently players get confused when they see reactor as the reason for their friends getting kicked from lobbies, at least due to not knowing what reactor is. The pr changes the message to indicate they don't have mods required by all players.

@js6pak
Copy link
Member

js6pak commented Jul 23, 2024

Thanks for the PR, but it has a few issues.
Firstly officials will "ban" you for either bypassing the chat cooldown or the message length limit.
And because you manually create the modsList string instead just using string.Join you will always end up with a comma at the end.

@js6pak js6pak closed this in 21c0e61 Jul 23, 2024
@js6pak
Copy link
Member

js6pak commented Jul 23, 2024

image

@Pietrodjaowjao
Copy link
Contributor

and ALSO illegal string

@Pietrodjaowjao
Copy link
Contributor

reactor should have a custom rpc for this instead

@js6pak
Copy link
Member

js6pak commented Jul 24, 2024

and ALSO illegal string

New lines are fine for now at least, we can change it to a comma later if needed.

reactor should have a custom rpc for this instead

This whole kicking mechanic is only used when both the server doesn't have Reactor handshake support (so on officials) and the joining player doesn't have Reactor installed at all. In any other case they will be kicked either by the server1 or the host with a custom GameData message2.

Footnotes

  1. https://github.com/NuclearPowered/Reactor.Impostor/blob/62b1e75710681df716c84606c807d8f93584180f/Reactor.Impostor/HandshakeEventListener.cs#L88

  2. https://github.com/NuclearPowered/Reactor/blob/21c0e61f57ec40677ec769167191f53336367453/Reactor/Networking/Patches/ClientPatches.cs#L141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants