Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a peer dependency on mongoose to satisfy pnpm's strict dependency… #63

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add a peer dependency on mongoose to satisfy pnpm's strict dependency… #63

wants to merge 2 commits into from

Conversation

restjohn
Copy link

@restjohn restjohn commented Mar 2, 2020

This pull request simply adds Mongoose @ versions 4-5 to to the peer dependencies of the sinon-mongoose package. This satisfies the strictness constraints of dependency managers pnpm and Yarn 2.

@restjohn restjohn closed this Mar 3, 2020
@restjohn restjohn reopened this Mar 3, 2020
@restjohn
Copy link
Author

restjohn commented Mar 3, 2020 •
edited
Loading

Unfortunately my pnpm build would not work when I added a restjohn/sinon-mongoose#pnpm git dependency because pnpm does not pull the dev dependencies and run the prepare script of git dependencies (yet). However, I still believe the change to the prepare script is valid because it works for npm and Yarn. The only slight issue is that npm also runs the prepare script when running npm install within a cloned sinon-mongoose working tree, the reason for which I'm not quite sure. Yarn behaves similarly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@restjohn