Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go 1.18 #404

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Go 1.18 #404

wants to merge 5 commits into from

Conversation

neb42
Copy link
Member

@neb42 neb42 commented May 9, 2022

Change go version in go.mod
Run go mod tidy

I've started using gvm to manage my go versions locally.

@ludydoo Unsure if there's anything else needed to upgrade to go 1.18?

@neb42 neb42 requested review from ludydoo and internetti May 9, 2022 07:46
@rational-terraforming-golem
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neb42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ludydoo
Copy link
Contributor

ludydoo commented May 9, 2022

@neb42 can you run go mod tidy on this? Seems it pulled a lot of stuff

@sonarcloud
Copy link

sonarcloud bot commented May 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@neb42
Copy link
Member Author

neb42 commented May 25, 2022

@ludydoo can this be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants