Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the "Hasura E2E tests chronicles, February 2023" chapter #41

Open
wants to merge 1 commit into
base: contract-testing-hasura
Choose a base branch
from

Conversation

NoriSte
Copy link
Owner

@NoriSte NoriSte commented Mar 29, 2023

Bring @NoriSte's article to the repo.

@NoriSte NoriSte requested a review from muratkeremozcan March 29, 2023 15:09

Let's start with a clean slate and think about the future! Some points that will positively impact the E2E tests:

1. We will consider **Playwright instead of Cypress** due to the speed and fewer resources required. The first round of using it went well. Now we need to check if it fulfills all our needs.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many problems, not related to the framework, but another framework is being considered.

If you have to hard wait in a test for a slow API, that test is going to be slow anywhere.

I am curious how this went.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It went nowhere since I no work there and, from what I know, they restarted writing e2e tests the old way and they have the same exact problems again...

Copy link
Collaborator

@muratkeremozcan muratkeremozcan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like Hasura doesn't have test architect, or a team of testers.

Can you summarize the layman's takeaways at the end? It's a good story, and what are the lessons the readers should learn from this, and not repeat your mistakes.

@NoriSte
Copy link
Owner Author

NoriSte commented Jun 10, 2023

Sounds like Hasura doesn't have test architect, or a team of testers.

Can you summarize the layman's takeaways at the end? It's a good story, and what are the lessons the readers should learn from this, and not repeat your mistakes.

I think the takeaways are

  1. Treat the e2e tests as a product and care about them. If they add friction or you do not have time to care about them, it's better not to have them at all
  2. Never hide the dust under the carpet with e2e tests, things can only get worse

WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants