In the error message, print value (%v) instead of assuming a string or byte slice (%s) #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r byte slice (%s) StatusText says it returns an string But http.StatusOK is returning a int resp.StatusCode is returning a int Since this is an error message, if it fails, might as well give the value as we received it in the error message. "data" is already being converted, so the %s works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StatusText says it returns an string
But
http.StatusOK is returning a int
resp.StatusCode is returning a int
Since this is an error message, if it fails, might as well give the value as we received it in the error message.
"data" is already being converted, so the %s works.