create persistent credentials provider #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dylanmei! It looks like you're the most recent contributor to this repo, so I hope it's alright that I tagged you. Just wanted get your thoughts on this PR! |
|
Hello @sarah-story the MR is most welcome. 🎉 We will get a review going. |
dylanmei
reviewed
Jun 13, 2022
| </dependencies> | ||
| </dependencyManagement> | ||
|
|
||
| <dependencies> | ||
| <dependency> | ||
| <groupId>com.google.guava</groupId> |
There was a problem hiding this comment.
Kindly share insights into the addition of Guava here.
|
@sarah-story is this PR still useful? |
|
Is this imrpovement still valid ? @sarah-story |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! My name is Sarah, and I'm a backend engineer at Zapier. We've been using your SQS sink connector, and we've made a few tweaks to it in our own fork. We are planning to submit a few pull requests with changes that we think would be useful to the community at large.
This PR introduces a change to the STS Assume Role auth provider. It moves the creation of the
CredentialsProviderinto theconfiguremethod. The benefit to this change is that theCredentialsProvideris only created once. ThengetCredentialswill use cached credentials until they expire, at which point therefreshmethod is called.At high volumes of events, we found that creating the
CredentialsProviderin thegetCredentialsmethod led to AWS rate limits. This change resolved the rate limit errors for us.